XWIKI-21523: Fields in form of WYSIWYG configuration are not accessible #2581
Conversation
* Added labels for the three elements in the form that failed because no accessible name.
| @@ -218,15 +218,19 @@ require(['jquery', 'xwiki-ckeditor', 'bootstrap-select'], function($, ckeditorPr | |||
| var commaSeparator = /\s*,\s*/; | |||
| var enhanceConfig = function(editor) { | |||
| var availablePlugins = editor.config.plugins.split(commaSeparator); | |||
| enhanceList($('#CKEditor\\.ConfigClass_0_removePlugins'), availablePlugins); | |||
| enhanceList($('#CKEditor\\.ConfigClass_0_removePlugins'), availablePlugins, 'availablepluginsselect'); | |||
There was a problem hiding this comment.
I'm not aware of any naming convention for ids, but I think it would be nice to use at least some way to differentiate words like camelCase.
There was a problem hiding this comment.
You are right. I don't know of one either.
When checking the string id=" in the codebase, it prompted a lot of things, but the most regularly used convention for IDs was camelCase.
I created a forum proposal to add a HTML codestyle appropriate for this situation: https://forum.xwiki.org/t/html-codestyle-proposal-conventions-for-ids-and-classes/13619
There was a problem hiding this comment.
Addressed in fb28aae 👍
There was a problem hiding this comment.
So apparently the proposal went for the kebab-case for ids so I guess you need to fix that now :)
There was a problem hiding this comment.
Addressed in 8599be3 👍
* Switched the IDs to camelCase
* Fixed case on ids to match new codestyle
Jira
https://jira.xwiki.org/browse/XWIKI-21523
PR Changes
View
We can see that this PR properly adds the relation between the label and the field (here, only the 'advanced' textarea field is showcased).